[Bug 1357573] Review Request: python-simpleeval - An expression evaluator library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1357573

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dan@xxxxxxxx
              Flags|                            |needinfo?(dan@xxxxxxxx)



--- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
1. I don't know why the main package and subackages have different summaries,
but if it's not intentional, you can use:

    Summary:        %{summary}

in subpackages.

2. I see no LICENSE, although it is in the GitHub repo.

3. %dir %{python3_sitelib}/__pycache__/

It is already owned by python3-libs, it is undesired to own it (although other
packages unfortunately do as well).

Other than that, it seems OK for the eyes-only check, will do formal review
once you fix 2. and 3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]