[Bug 1342063] Review Request: python-mongoquery - A python implementation of mongodb queries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1342063

Igor Gnatenko <ignatenko@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ignatenko@xxxxxxxxxx



--- Comment #3 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
> Source0:        https://github.com/kapouille/%{srcname}/archive/v%{version}.tar.gz
-> Source0:        %{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz

> BuildRequires:  python2-devel python3-devel python-nose python3-nose
split those to subpackages and replace python-nose with python2-nose

> %if 0%{?rhel} && 0%{?rhel} <= 6
> %{!?__python2: %global __python2 /usr/bin/python}
> %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> %{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
> %endif
You don't build this package for RHEL6 and below, so drop it.

> %if ! 0%{?rhel} || 0%{?rhel} > 6
same

> %global sum A python implementation of mongodb queries
move this to `Summary` tag and use further as %{summary}.

> Group:          Development/Languages
drop it

> License:        Unlicense
not sure if it's valid license (just check on licensing wikipage)

Also it would be better if you will do:
%global _description \
....

and then for each package do:
%description -n python3-%{srcname} %{_description}

Python 3 version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]