[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1348160

Vít Ondruch <vondruch@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vondruch@xxxxxxxxxx



--- Comment #9 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
(In reply to Francesco Frassinelli (frafra) from comment #7)
> I would suggest to avoid env for Fedora packages for two reasons:
> 
> 1. Fedora wiki suggests to use #!/usr/bin/ruby and #!/usr/bin/python
> 2. You don't want to get different behaviour/errors from your system tools
> when you are in a virtualenv (or ruby equivalent)
> 
> I think that env is fine for upstream code and bad for system packages.
> There are a lot of spec file replacing shebangs using env.

While your both points are valid, we typically don't change the shebangs in
rubygems.

The thing is that the executable, which is installed into /usr/bin has always
the /usr/bin/ruby shebang, since this is generated file. There is just minimal
chance, that the files which goes into %{gem_instdir}, or even files which goes
into %{gem_instdir}/bin will be executed directly by user, so there is no real
reason to change the shebangs IMO (unless you want to avoid the Requires:
/usr/bin/env autogenerated by RPM, but in that case, it might be better to
filter this autogenerated Requires ...)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]