https://bugzilla.redhat.com/show_bug.cgi?id=1334112 Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e@xxxxxxxxxxxxxxxx Blocks| |1346060 Assignee|ignatenko@xxxxxxxxxx |e@xxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> --- - Spec file as given by url is not the same as in SRPM. Please update the Spec you provide in Spec URL. - License text not included. You must include it by using the %license macro. See: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text - Upstream changed license from LGPLv2+ to GPLv2+, but they did not update the copyright statement in the beginning of every source code file. Please report this. Also, the COPYING file included in the tarball is LGPLv2, which does not reflect the change in https://github.com/projectmallard/pintail/commit/a15500c3fd936f58bc88f5a8aa47dd365d8414b2 - rpmlint complains: pintail.noarch: E: explicit-lib-dependency python3-urllib3 -- this is an automatic dependency, no need to add it in the Spec pintail.noarch: W: summary-not-capitalized -- please use Build web sites... pintail.noarch: E: description-line-too-long -- no more than 79 characters per line - Changelog format is not consistent for all entries. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1346060 [Bug 1346060] Review Request: python-pintail-asciidoc - Use AsciiDoc pages in Pintail sites -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx