https://bugzilla.redhat.com/show_bug.cgi?id=1353598 --- Comment #8 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Jerry James from comment #7) > Issues > ====== > - Multiple licensing issues must be explained with a comment in the spec > file. > For some ideas on how this might be done, see > > https://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Multiple_Licensing_Scenarios > > - The portions of the code with the Apache license have JBoss copyright > notices. > Is this bundled code? No, i hope, but seem all JBoss and Hibenate projects switch their license to ASL 2.0 in the near future Please, attached the generated licensecheck.txt files is is available. so take a look in the source code headers ... > - There are some file copies without -p, for SOURCE1 through SOURCE10. > Perhaps > -p should be added to preserve timestamps. Done > - Could you ask upstream to update lgpl.txt to a version with the correct FSF > address? Version 2.1 is available here: > http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt reported @ https://hibernate.atlassian.net/browse/HHH-10961 but usually hibernate developer dont care about these problems > Package Review > ============== > ===== MUST items ===== > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. Some wrote above > ===== SHOULD items ===== > > Generic: > [!]: %check is present and all tests pass. Not available test deps as commented in the spec file > [!]: Packages should try to preserve timestamps of original installed > files. Done Spec URL: https://gil.fedorapeople.org/hibernate4.spec SRPM URL: https://gil.fedorapeople.org/hibernate4-4.3.11-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx