https://bugzilla.redhat.com/show_bug.cgi?id=1338556 Athmane Madjoudj <athmanem@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |athmanem@xxxxxxxxx --- Comment #2 from Athmane Madjoudj <athmanem@xxxxxxxxx> --- Hi Graham, I'm not a sponsor so I cant do full review (afaik). Please consider the following points related to Apache httpd modules packaging best practices (ie: not in the guidelines but should be implemented): 1. You should include a config file that loads the module eg "20-mod_ical.conf", then install it into httpd modules config dir. # cat 20-mod_ical.conf LoadModule ical_module modules/mod_ical.so Spec changes: ... Source1: 20-mod_ical.conf ... ... install -Dp -m0644 %{SOURCE1} %{buildroot}%{_httpd_modconfdir}/20-mod_ical.conf ... 2. The module should require httpd binary interface that was built on, ie add: Requires: httpd-mmn = %{_httpd_mmn} 3. You should use macros instead of hardcoded paths, ie: Replace "%{_libdir}/httpd/modules/mod_ical.so" with "%{_httpd_moddir}/mod_ical.so" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx