[Bug 1352065] Review Request: gst-transcoder - GStreamer Transcoding API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1352065



--- Comment #14 from Jon Ciesla <limburgher@xxxxxxxxx> ---
(In reply to Igor Gnatenko from comment #12)
> > Requires: %{name} = %{version}-%{release}
> MUST: missing %{?_isa}

Fix

> > %{_datadir}/gir-1.0/
> not sure if it's good idea to own gir/typelib directories directly instead
> of requiring gobject-introspection

This seems to be how other packages with files here do it.

> > %{_libdir}/libgsttranscoder-1.0.so
> MUST: this should go to -devel
> 
It's required at runtime.

> > make %{?_smp_mflags}
> %make_build

Fixed

> > ./configure --prefix=/usr
> MUST: %configure

The configure macro fails.

> > make install DESTDIR=%{buildroot}
> %make_install
> 
Fixed

> > Requires: gstreamer1-devel
> MUST: missing %{?_isa}

Fixed.

I had updated the spec, and have now as well.

SRPM:
https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder-1.8.0-3.fc24.src.rpm
SPEC: https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]