https://bugzilla.redhat.com/show_bug.cgi?id=1355871 --- Comment #5 from Jeremy Cline <jeremy@xxxxxxxxxx> --- Spec URL: https://jcline.fedorapeople.org/python-clint.spec SRPM URL: https://jcline.fedorapeople.org/python-clint-0.5.1-1.fc25.src.rpm (In reply to Igor Gnatenko from comment #1) > > rm docs/_build/html/objects.inv > I would not do this, because it's needed for linking from another projects, > but remove ".doctrees" directory I've stopped removing the intersphinx inventory, but I'm not sure where you're seeing seeing the .doctrees directory packaged. Can you clarify? > > > %doc README.rst HISTORY.rst AUTHORS > I would not put this stuff into -doc subpkg as it is already in py2, py3 pkgs My opinion is this is fine. In fact, I would argue that at the AUTHORS file at least _should_ be in the package. > > > no tests > https://github.com/kennethreitz/clint/blob/master/test_clint.py > actually there is (sort of) There are no tests in the latest tagged release. I've updated the comment to make that clearer. (In reply to Igor Gnatenko from comment #2) > missing BuildRequires: pythonX-setuptools I've added explicit BuildRequires for both. (In reply to Igor Gnatenko from comment #3) > instead of second patch I would recommend to do: > rm -vrf %{srcname}/packages/ > in %prep > > and instead of 1st patch I would run sed with some special arguments, so you > will never miss any import. My preference is to stick with the patches. This is a very small library and does not look very active (at all) upstream. I find the patches much clearer from a maintainer's point of view. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx