https://bugzilla.redhat.com/show_bug.cgi?id=1352714 --- Comment #3 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- > Requires: %{name} = %{version}-%{release} missing %{?_isa} > Requires: pkgconfig not needed > %setup -q > %autosetup only one should be choosen > make not %{_smp_mflags}, better to use %make_build > make DESTDIR=%{buildroot} install can be %make_install > %{_libdir}/libsoupsharpglue-2.42.2.so 2.42.2 -> %{version} > %{_libdir}/libsoupsharpglue*.la libtool files should not be packaged > %{_libdir}/libsoupsharpglue*.a static libraries should not be packaged or can be packaged to special -static subpkg (but I don't recommend to do this) > Source0: https://github.com/stsundermann/%{name}/archive/%{version}.zip#/%{name}-%{version}.tar.gz .zip -> .tar.gz something wrong here. also you canuse %{url} instead of https://github.com.... until /archive so, not ready ;) * Missing BuildRequires for compiler.. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx