https://bugzilla.redhat.com/show_bug.cgi?id=1352380 Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |e@xxxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |e@xxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> --- Taking the review. I'll take care of the sponsoring process. - rpmlint's output is not clean: python-parsimonious.noarch: W: incoherent-version-in-changelog 0.6.2 ['0.6.2-1.fc25', '0.6.2-1'] See: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs - The package must provide python2-parsimonious. Since there will be Python 3 support in the near future, it's best to create python2-parsimonious and python3-parsimonious subpackages. See: https://fedoraproject.org/wiki/Packaging:Python#Provides See: https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file - I do not understand the point of the conditional. You don't use the value of with_python3 in any place in the Spec. Please address these issues and I'll review it again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx