[Bug 1341641] Review Request: pytest-runner - Invoke py.test as distutils command with dependency resolution

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1341641

Athmane Madjoudj <athmanem@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #2 from Athmane Madjoudj <athmanem@xxxxxxxxx> ---
Hi Matej,

Could you please look into the following points:

1. Use macros provided in the guidelines instead of using:  Provides: 
python3-%{name} or Provides:  python2-%{name} , it'll make switching to py3 as
default easier (I guess)

%{?python_provide:%python_provide python2-%{srcname}}

<and>

%{?python_provide:%python_provide python3-%{srcname}}

2. The current python naming convention is: python-<PyPI name>, the package
should be renamed python-pytest-runner
   You can use "dnf search pytest" to look into other packages names


3. (not a blocker): I you want to reduce custom macros, you can use %{summary}
macros instead of %{sum}, eg:


Name:               pytest-runner
Version:            2.8
Release:            1%{?dist}
Summary:            Invoke py.test as distutils command with dependency
resolution

[...]

%package -n python2-%{srcname}
Summary:        %{summary}
%{?python_provide:%python_provide python2-%{srcname}}

--
[*] https://fedoraproject.org/wiki/Packaging:Python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]