[Bug 1354512] Review Request: xdg-desktop-portal - Portal frontend service to flatpak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1354512



--- Comment #2 from David King <amigadave@xxxxxxxxxxxxx> ---
(In reply to Igor Gnatenko from comment #1)
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/share/doc/xdg-desktop-portal
>      -> don't use %doc with %{_pkgdocdir}

The guidelines do not forbid that, but instead forbid mixing relative and
absolute paths in a %doc directive. I changed to "%doc %{_pkgdocdir}" instead
(as the build system installs files into pkgdocdir). Or, did you mean to just
drop the "%doc" entirely and just include "%{_pkgdocdir}" in the files list?

> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/doc/xdg-desktop-
>      portal, /usr/share/dbus-1, /usr/share/dbus-1/interfaces,
>      /usr/share/dbus-1/services
>      -> add to requirements dbus or something like this

I added a Requires on dbus.

> [!]: Package consistently uses macros (instead of hard-coded directory
>      names).
>      -> you could use %{url} in Source0 tag

This is a matter of style according to
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros so I have left it
unchanged.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]