[Bug 1327160] Review Request: unibilium - Terminfo parsing library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1327160



--- Comment #2 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
> The MIT/X11 license is not in the .spec file under the License tag
only tests are under that license

> The %license macro should be specified in the .spec file
it is used.

> Also perhaps the MIT license should be mentioned in the LICENSE file
see above.

> makeinstall macro is used instead
don't see what's wrong here

> According to the Packaging Guidelines the makeinstall macro should not be used
%makeinstall not, but %make_install yes. don't see problems here

> Perhaps you should use https://github... form of URL for the Source0 tag
no, URL is correct and downloadable

> %check is not present
hm, forgot it. fixing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]