[Bug 1336164] Review Request: golang-github-bgentry-go-netrc - netrc file parser for Go programming language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1336164



--- Comment #1 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
Summary:

- licences OK
- example provides testing files for unit-tests => ok to include them in the
unit-test subpackge
- will not build in epel6 (%license macro is not defined)
- usually structure (with_* removed)

Running rpmlint golang-github-bgentry-go-netrc-0-0.1.git9fd32a8.fc20.src.rpm
golang-github-bgentry-go-netrc-devel-0-0.1.git9fd32a8.fc20.noarch.rpm
golang-github-bgentry-go-netrc-unit-test-devel-0-0.1.git9fd32a8.fc20.x86_64.rpm
golang-github-bgentry-go-netrc.src: W: summary-not-capitalized C netrc file
parser for Go programming language
golang-github-bgentry-go-netrc.src: W: spelling-error %description -l en_US
whitespace -> white space, white-space, whites pace
golang-github-bgentry-go-netrc-devel.noarch: W: summary-not-capitalized C netrc
file parser for Go programming language
golang-github-bgentry-go-netrc-devel.noarch: W: spelling-error %description -l
en_US whitespace -> white space, white-space, whites pace
golang-github-bgentry-go-netrc-unit-test-devel.x86_64: W: spelling-error
%description -l en_US whitespace -> white space, white-space, whites pace
golang-github-bgentry-go-netrc-unit-test-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=14858035

Nits:
- fix summary, first letter must by capitalized (s/netrc/Netrc).

Otherwise LGTM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux