https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #11 from Raphael Groner <projects.rg@xxxxxxxx> --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14855484 (In reply to Igor Gnatenko from comment #10) > > %{?!_pkgdocdir:%global _pkgdocdir %{_docdir}/%{name}} > could be removed Needed for EPEL7, %{_pkgdocdir} is not defined there. > > mkdir -p %{_target_platform} > better to move into %prep We don't want an empty folder created for rpmbuild -bp, it's common practice to do it so in %make. > > cp -ap examples %{buildroot}%{_pkgdocdir} > just mark as %doc in -doc subpkg Guidelines forbid to mix %doc with %{_pkgdocdir}. We've to use %{_pkgdocdir} cause you instructed me to use cmake installation of documentation files, the examples folder is an addition. https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation > > pushd %{_target_platform}/tests > > ctest %{?_smp_mflags} > don't pushd to tests, just to _target_platform > add -VV to ctest invocation to easy identify bugs if there > also do popd after Fixed. Although, popd is obsolete. -VV does not give any obvious improvement to build.log, anyways added. > > %{_pkgdocdir}/ > mark as %doc Useless, see above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx