Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ois - Open Input System, OO gaming input library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246386 packages@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED OtherBugsDependingO|241900 | nThis| | Flag| |fedora-review? ------- Additional Comments From packages@xxxxxxxxxxxxxxxxxx 2007-07-01 15:04 EST ------- * rpmlint: W: ois-devel no-documentation Harmless and ignorable. W: ois unused-direct-shlib-dependency /usr/lib/libOIS-1.0.0.so /usr/lib/libXaw.so.7 W: ois unused-direct-shlib-dependency /usr/lib/libOIS-1.0.0.so /lib/libm.so.6 These can be a total PITA to try and fix, but not a blocker. * Package named correctly: Yes * Patches named correctly: N/A * Spec file named correctly: Yes * Licence field matches: Yes * Licence file installed: Yes (and included upstream) * Spec file in American English: Yes * Source matches upstream: Yes * Locales use %find_lang: N/A * Contains %clean: Yes * Specfile legible: Yes * Compiles and builds ok: Yes (mock: fc6/ppc, f7/i386, f8/x86_64) * Calls ldconfig in %post/%postun for shlibs: Yes * Owns directories it creates: Yes * Duplicate files: No * Permissions set correctly: Yes * Consistent macro use: Yes * %doc affects runtime: No * Headers and static libs in -devel: Yes * .pc files in -devel: Yes * .so in -devel: Yes * -devel requires base: Yes * Contains .la files: No * Owns files it didn't create: No * .desktop files installed correctly: N/A Just noticed the changelog says "Sat Jul 1 2007" but July 1st is a sunday :-) APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review