https://bugzilla.redhat.com/show_bug.cgi?id=1309794 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |projects.rg@xxxxxxxx --- Comment #1 from Raphael Groner <projects.rg@xxxxxxxx> --- Review swap with bug #1354184. Thanks for your interest! Below are some general hints before I can do an official review. 1. Why do you use GPLv2 instead of GPLv2+? I don't see a restriction in sources, the COPYING file clearly says "or later": GNU General Public License v2.0 only GPLv2 GNU General Public License v2.0 or later GPLv2+ 2. Add Requires: hicolor-icon-theme, for ownership of %{_datadir}/icons/hicolor/ 3. Add documentation files: %files %doc AUTHORS CHANGELOG README - Recommendations: 4. Can you build with Qt5 instead of Qt4? Qt4 development is stalled, but some of the used classes are not available in Qt5: http://stackoverflow.com/questions/26180311/qhttp-in-not-available-in-qt5 https://forum.qt.io/topic/23904/qtftp-and-qthttp-compatibility-add-ons-for-qhttp-and-qftp-classes-in-qt-5/3 You may also need a patch for the pro file: sed -i -r 's/(VER = ).*/\1QT_VERSION/' src/%{name}.pro 5. My preference is to use BuildRequires: desktop-file-utils, instead of giving a concrete path of own file desktop-file-validate. 6. Simplify build and install commands in a more convinient way: %build mkdir -p %{_target_platform} pushd %{_target_platform} %qmake_qt4 ../src/%{name}.pro PREFIX=%{_prefix} popd %make_build -C %{_target_platform} %install %make_install -C %{_target_platform} INSTALL_ROOT=%{buildroot} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx