https://bugzilla.redhat.com/show_bug.cgi?id=1270322 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #56 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Naming: ok Licensing: ok 1. SHOULD: can you confirm that OpenSSL is still needed? during review of qtwebengine (which bundles chromium), we determined that (only) nss was used there. sources: ok kinda have to take your word for it here, as the source generation is scripted to remove patented sources (and possibly not 100% reproducible) scriptlets: ok macros: ok file/directory ownership: ok 2. SHOULD consider %lang'ifying %{chromium_path}/locales/ content (or add a .spec comment why this is not possible or practical or whatever). builds/installs/runs: ok changelog format: ok -debuginfo: ok 3. SHOULD: good enough for now, thought it's current size of ~10mb makes me question whether the buildsystem may be stripping -g debug flags too aggressively to make the -debuginfo useful. bundling: ok another... good enough for now, given fedora' relaxed bundling policies, I think anything that can be reasonably unbundled is being done. 4. SHOULD consider cleaning .spec of some deprecated tags, including: BuildRoot: Group: %defattr %clean 5. SHOULD. we found in qtwebengine, v8 code needed -fno-delete-null-pointer-checks to avoid some crashing, see also: https://bugs.chromium.org/p/v8/issues/detail?id=3782 you might want to add that here too. After looking things over closely, that's all I could come up with, which didn't actually include any blockers. So, I'm happy to mark this APPROVED. may the force be with you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx