https://bugzilla.redhat.com/show_bug.cgi?id=1317282 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx Blocks|177841 (FE-NEEDSPONSOR) | Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review+ --- Comment #7 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- Sorry for the delay! You don't need to rm -rf %{buildroot} at the beginning of %install, that's done by default on every version of RPM (except the one in RHEL 5). Otherwise, your package is clean. Please fix that before you commit. == REVIEW == Good: - rpmlint checks return: bspwm.src: W: spelling-error %description -l en_US bspc -> tbsp bspwm.src: W: spelling-error %description -l en_US sxhkd bspwm.x86_64: W: spelling-error %description -l en_US sxhkd All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (BSD) OK, text in %license, matches source - spec file legible, in am. english - source matches upstream - package compiles on Fedora 24 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file properly handled Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx