[Bug 1350029] Review Request: libi40iw - userspace rdma library for Intel Ethernet Connection X722

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1350029

Igor Gnatenko <ignatenko@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ignatenko@xxxxxxxxxx



--- Comment #15 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
Unfortunately it's not yet good package.

> %defattr(-,root,root,-)
MUST be dropped

> %clean
> rm -rf %{buildroot}
MUST be dropped

> make %{?_smp_mflags}
COULD be replaced iwth %make_build

> make DESTDIR=%{buildroot} install
COULD be replace with %make_install

> %setup -q -n %{name}-%{version}
COULD be changed to %setup -q or to %autosetup

> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
MUST be dropped

> Group: System Environment/Libraries
> Group: System Environment/Libraries
COULD be dropped

> %package devel-static
It's actually not devel-static, but just static. Please adjust.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]