Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: brutus-keyring - small and simple keyring daemon based upon libgcrypt Alias: brutus-keyring https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246227 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-07-01 10:01 EST ------- (In reply to comment #6) > (In reply to comment #5) > > Well, for 0.9.0-2: > > > > * Comments > > - Are the comments above Summary entry needed? > > I suggest to remove them > > I'm confused here. Which comments do you mean? > There are a few empty lines above > "Summary" in the spec file, but those are mandated by my support of other RPM > based distributions (SUSE 10.2 and 10.3). - What I meant here is the parts of ------------------------------------------------ # RPM spec file for the Brutus Keyring. # Copyright (C) 2007 OMC Denmark ApS <snip> # Foundation, Inc., 59 Temple Place, Suite 330, Boston, # MA 02111-1307 USA # ------------------------------------------------ (In reply to comment #8) > (In reply to comment #6) > > > - Check the Requires for -devel subpackage. > > > Especially, check the description in > > > libBrutusKeyringd-1.0.pc . > > > On second thoughts... the devel package require the non-devel package which > require libIDL and ORBit2 so the devel package shouldn't > require any of those by > itself. Right? - The point is not there. /usr/lib/pkgconfig/libBrutusKeyringd-1.0.pc contains the line: --------------------------------------------------- Requires: libIDL-2.0 >= 0.8.5, ORBit-2.0 >= 2.14.1 --------------------------------------------------- This means that brutus-keyring-devel must have "Requires: ORBit2*-devel*" (and /usr/include/brutus-keyring-1.0/brutus-keyring.h also requires ORBit2-devel) (the dependency for ORBit2 is automatically pulled). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review