https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman <nhorman@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(dennis.dalessandr | |o@xxxxxxxxx) --- Comment #28 from Neil Horman <nhorman@xxxxxxxxxx> --- It looks like at some point in your update you removed the _smp_mflags macro: [!]: Uses parallel make %{?_smp_mflags} macro. Its not a huge deal, I can let that slide, but please fix it when you check it in. Also, something just occured to me. Is this verb library named libhfi1 because its meant to supersede libhfi? If so, you might consider renaming it upstream, and just using the epoch tag in the spec to make sure the upgrade path is right. Doing so would let you avoid the obsoletes tag requirements, as you we could update the libhfiverbs package that exists. The question to really answer is "is libhfiverbs still under active development"? If it is, then you proably want what you have. If not, and if libfhi1 is compatible with libhfi in terms of hardware, then you may want to consider renaming the package upstream. Let me know what you want to do. If you are happy with the way it currently is, then I can approve this as it is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx