Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: brutus-keyring - small and simple keyring daemon based upon libgcrypt Alias: brutus-keyring https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246227 ------- Additional Comments From colding@xxxxxxxxx 2007-07-01 02:34 EST ------- (In reply to comment #5) > Well, for 0.9.0-2: > > * Comments > - Are the comments above Summary entry needed? > I suggest to remove them I'm confused here. Which comments do you mean? There are a few empty lines above "Summary" in the spec file, but those are mandated by my support of other RPM based distributions (SUSE 10.2 and 10.3). > * Requires > - Check the Requires for -devel subpackage. > Especially, check the description in > libBrutusKeyringd-1.0.pc . You are right. Those requirements was different. I've added the requirements for libIDL and ORBit2 to the devel package. > ? Conflicts > - By the way, currently Fedora's newest evolution-brutus is > 1.1.26.2-2.fc7. This srpm means that Fedora's > evolution-brutus has to be updated? Yes. e-b<=1.1.28 installs brutus-keyring by itself. Separating brutus-keyring and e-b is really the right thing to do technically. I've pushed the e-b modifications to svn (svn.brutus.net) for Brian to pick up. > * Documents > - Please install the following > ---------------------------------------------- > AUTHORS > ChangeLog OK, done. > ---------------------------------------------- > - On the other hand, I suggest to remove the following > ---------------------------------------------- > INSTALL - This file is needed for people who want to > build and install this package by themselves and > is not needed for people who use rpm package. > ---------------------------------------------- OK, removed. New files here: Spec URL: http://www.omesc.com/sites/default/files/downloads/dist/brutus-keyring/Fedora%207/SPECS/brutus-keyring.spec SRPM URL: http://www.omesc.com/sites/default/files/downloads/dist/brutus-keyring/Fedora%207/SRPMS/brutus-keyring-0.9.0-3.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review