https://bugzilla.redhat.com/show_bug.cgi?id=1346382 --- Comment #8 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Sandro Mani from comment #7) > The only comments I have are: > > * For a prettier source name, you could use > https://github.com/picketlink/picketlink/archive/v%{namedversion}/%{name}- > %{version}.tar.gz Done, used https://github.com/picketlink/picketlink/archive/v2.7.1.Final/picketlink-2.7.1.Final.tar.gz > * [!]: %check is present and all tests pass - I see some files which look > like test sources, but I can't judge whether these are utilizable for %check a maven style build don't need the check section, because test suites are executed in the same command line by default > Rest looks good to me, approved. Spec URL: https://gil.fedorapeople.org/picketlink.spec SRPM URL: https://gil.fedorapeople.org/picketlink-2.7.1-2.fc23.src.rpm Thanks for the review! created new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/6257 https://admin.fedoraproject.org/pkgdb/package/requests/6256 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx