https://bugzilla.redhat.com/show_bug.cgi?id=1348932 William Moreno <williamjmorenor@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23 |rawhide --- Comment #4 from William Moreno <williamjmorenor@xxxxxxxxx> --- Hi, just a few comments: 1. Al new packages must go to rawhide, I hace just fixed the tag. 2. There is no need of %%clean seption at less than you want to go to epel 6 or epel 5, also you must remove the rm -rf %{buildroot} command in the begginig of %install. 3. Add ad comment to the %build section to avoid a rmplint issue about ampy %%buil 4. The url tag shuld be https://github.com/magicmonty/bash-git-prompt without the .git 5. There is not problem with use a already existing spec but update the changelog: Fri Aug 08 2014 Justin Zhang <schnell18@xxxxxxxxx - 1.0.1-1 I guess at less you made a versión bump. 6. Send a pull request with the updated spec. 7. Finally %post and %postun should go after %%install (or %%?check), can find a example here: http://pkgs.fedoraproject.org/cgit/rpms/exaile.git/tree/exaile.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx