Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ndesk-dbus - Managed DBus implementation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245491 ------- Additional Comments From peter@xxxxxxxxxxxxxxxx 2007-06-30 17:37 EST ------- David: Thanks for fixing the issues I brought up. The only thing left is that it does not build in Mock (Development). However, this appears to be an error with the mono packages' dependency tree. My attempt created the following in the build.log file: [...] --> Finished Dependency Resolution Error: Missing Dependency: libglib-2.0.so.0 is needed by package mono-devel Error: Missing Dependency: libz.so.1 is needed by package mono-core Error: Missing Dependency: libgcc_s.so.1(GCC_3.3.1) is needed by package mono-core Error: Missing Dependency: libgcc_s.so.1(GCC_3.0) is needed by package mono-devel Error: Missing Dependency: libgcc_s.so.1 is needed by package mono-core Error: Missing Dependency: libglib-2.0.so.0 is needed by package mono-core Error: Missing Dependency: libgcc_s.so.1(GCC_3.0) is needed by package mono-core Error: Missing Dependency: libgthread-2.0.so.0 is needed by package mono-core Error: Missing Dependency: libgcc_s.so.1 is needed by package mono-devel Error: Missing Dependency: libgthread-2.0.so.0 is needed by package mono-devel Error: Missing Dependency: libgmodule-2.0.so.0 is needed by package mono-core Error: Missing Dependency: libgcc_s.so.1(GCC_3.3.1) is needed by package mono-devel build DEBUG: Executing timeout(0): /usr/sbin/mock-helper chroot /var/lib/mock/fedora-development-x86_64/root /sbin/runuser - root -c "cd /;/sbin/runuser -c 'rpmbuild --rebuild --target x86_64 --nodeps /builddir/build/SRPMS/ndesk-dbus-0.5.2-4.fc8.src.rpm' mockbuild" Installing /builddir/build/SRPMS/ndesk-dbus-0.5.2-4.fc8.src.rpm Building target platforms: x86_64 Building for target x86_64 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.59257 + umask 022 [...] Thus, these two BR packages do not get installed into the buildroot. However, I just tested this and it does indeed build fine in an F-7 mock run. Therefore, I won't consider that a blocker. (Alas, I had not realized at first that mono-core is a runtime dependency of mono-devel, so mono-core should not be an explicit BR.) However, there is still work needed to be done on this package before it can be accepted: > W: ndesk-dbus summary-not-capitalized ndesk-dbus is a C# implementation of D-Bus. > W: ndesk-dbus summary-ended-with-dot ndesk-dbus is a C# implementation of D-Bus. > W: ndesk-dbus mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 1) (1) Please fix your Summary and your inconsistency of tabs/space usage. > W: ndesk-dbus unversioned-explicit-obsoletes dbus-sharp > W: ndesk-dbus unversioned-explicit-provides dbus-sharp You need to give an E:V-R to these tags, making it explicitly larger than that of dbus-sharp to provide a proper upgrade path for users. Please see: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PackageRename for more information. > W: ndesk-dbus macro-in-%changelog setup This is really bad. Unfortunately, macros in the %changelog do also expand and cause unexpected troubles later. Remove the macro or escape it by using an extra percent sign (e.g., "%%setup" and "%%macro_here"). > E: ndesk-dbus no-binary > E: ndesk-dbus only-non-binary-in-usr-lib These two say that the package has no binaries in it, but this is a Mono library which RPM still has troubles identifying, it seems. Thus, these seem harmless. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review