[Bug 1344115] Review Request: winetricks - Work around common problems in Wine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1344115



--- Comment #9 from Lumír Balhar <lbalhar@xxxxxxxxxx> ---
(In reply to Ville Skyttä from comment #8)
> (In reply to Lumír Balhar from comment #7)
> 
> > - remove these dependencies: gzip unzip which
> 
> The which dependency cannot be removed. winetricks requires it, and nothing
> in its dependency chain pulls it in. (gzip and unzip are being pulled in by
> others so they can be dropped if you like)
> 
> The wget dependency should on the other hand still be removed, see comment 4.
> 
> And I'm not sure where the time dependency comes from, can't find a place
> where it would be used. So I suppose that dep should go as well.

Look at issue in review output:

> All build dependencies are listed in BuildRequires, except for any that
> are listed in the exceptions section of Packaging Guidelines.
> Note: These BR are not needed: gzip unzip which
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

I think 'which' is not needed in BR (like gzip and unzip).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]