https://bugzilla.redhat.com/show_bug.cgi?id=1350148 --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Great thanks for taking this review. > [x]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. > > I assume the above is allowed due to it not being a system wide library. This is not a library, only an extension, so indeed, OK. > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/doc/pecl > > This directory is owned by php-pear, which is only a BuildRequires. However > it installs documentation there so should probably have a Requires on > php-pear if I'm not mistaken? No we don't want to require php-pear, see Fedora 24 feature https://fedoraproject.org/wiki/Changes/drop_pear_dep Can you please file a bug against PHP (F24) which should own this dir, obviously not this package. > [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. This is only a should, not a blocker BTW: https://github.com/remicollet/remirepo/commit/89902df76f6f0c401760e0026b9fb57ff0308fe8 Spec: https://raw.githubusercontent.com/remicollet/remirepo/89902df76f6f0c401760e0026b9fb57ff0308fe8/php/pecl/php-pecl-apcu-bc/php-pecl-apcu-bc.spec Srpm: http://rpms.remirepo.net/SRPMS/php-pecl-apcu-bc-1.0.3-3.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx