https://bugzilla.redhat.com/show_bug.cgi?id=1318988 --- Comment #34 from jiri vanek <jvanek@xxxxxxxxxx> --- (In reply to Severin Gehwolf from comment #30) > [!] Changelog is not in prescribed format: > java-1.8.0-openjdk-aarch32.armv7hl: W: incoherent-version-in-changelog > 1:1.8.0.xx-1.bb ['1:1.8.0.76-1.160415.fc24', '1:1.8.0.76-1.160415'] > Use "1:1.8.0.76-1.160415" rather "than 1:1.8.0.xx-1.bb" fixed > [!]: Sources used to build the package match the upstream source, as > provided in the spec URL. > Used the following command to generate the source tarball locally: > $ PROJECT_NAME=aarch32-port VERSION=jdk8u76-b00-aarch32-160415 > REPO_NAME=jdk8u \ > bash ../generate_source_tarball.sh > where "generate_source_tarball.sh" is as in the main java-1.8.0-openjdk > dist-git repo. > $ md5sum aarch32-port-jdk8u-jdk8u76-b00-aarch32-160415.tar.xz > f4e5fa08100e18a8ed74180bcb98aea2 > aarch32-port-jdk8u-jdk8u76-b00-aarch32-160415.tar.xz > From the SRPM: > $ md5sum > srpm-unpacked/aarch32-port-jdk8u-jdk8u76-b00-aarch32-160415.tar.xz > 73127e42f6536fd0c10b0237ac0ee808 > srpm-unpacked/aarch32-port-jdk8u-jdk8u76-b00-aarch32-160415.tar.xz > Perhaps I'm doing something wrong? There is nothing I can do about this. You know that openjdk do not do releases. They tag, and anybody can clone. The tar/zip archives are generally not reproducible(timestamps), and I don't think that there is serious reason to force the reproducibiity. In addition I'm providing scrip twhich can regenerate osurces by one click. > [!] Mixed use of tabs and spaces in spec: > srpm/java-1.8.0-openjdk-aarch32.spec:634: W: mixed-use-of-spaces-and-tabs > (spaces: line 8, tab: line 634) fixed > > > Package Review > ============== > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > > ===== MUST items ===== > > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [x]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. > [?]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. > It mentions GPL v2 + Classpath Exception. I did not check if others are > still relevant. This should be ok. > [?]: License file installed when any subpackage combination is installed. > [?]: Package requires other packages for directories it uses. > [?]: Package must own all directories that it creates. The oownership should be correct.What is not owned by jdk itself, is owned by jpackage-toosl or other dependencies. > [x]: Package contains no bundled libraries without FPC exception. > Bundled LCMS libs are being used. This is a known work-around. > [!]: Changelog in prescribed format. fixed > [x]: Sources contain only permissible code or content. > [x]: Package contains desktop file if it is a GUI application. > [x]: Development files must be in a -devel package > [?]: Package uses nothing in %doc for runtime. that is correct. > [-]: Package consistently uses macros (instead of hard-coded directory > names). Of course it does:) > [x]: Package is named according to the Package Naming Guidelines. ... > [x]: Package is not relocatable. > [!]: Sources used to build the package match the upstream source, as > provided in the spec URL. > Used the following command to generate the source tarball locally: > $ PROJECT_NAME=aarch32-port VERSION=jdk8u76-b00-aarch32-160415 > REPO_NAME=jdk8u \ > bash ../generate_source_tarball.sh > where "generate_source_tarball.sh" is as in the main java-1.8.0-openjdk > dist-git repo. > $ md5sum aarch32-port-jdk8u-jdk8u76-b00-aarch32-160415.tar.xz > f4e5fa08100e18a8ed74180bcb98aea2 > aarch32-port-jdk8u-jdk8u76-b00-aarch32-160415.tar.xz > From the SRPM: > $ md5sum > srpm-unpacked/aarch32-port-jdk8u-jdk8u76-b00-aarch32-160415.tar.xz > 73127e42f6536fd0c10b0237ac0ee808 > srpm-unpacked/aarch32-port-jdk8u-jdk8u76-b00-aarch32-160415.tar.xz As described above. <snip> In meantime updated to latest u91 of aarch32 8u project. How do you feel about it now? https://jvanek.fedorapeople.org/java-1.8.0-openjdk-aarch32-jit/7/java-1.8.0-openjdk-aarch32-1.8.0.91-1.160510.fc24.src.rpm https://jvanek.fedorapeople.org/java-1.8.0-openjdk-aarch32-jit/7/java-1.8.0-openjdk-aarch32.spec scracth build in progress: http://koji.fedoraproject.org/koji/taskinfo?taskID=14701925 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx