https://bugzilla.redhat.com/show_bug.cgi?id=1350884 --- Comment #2 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Some quick drive-by comments: I think the package name should be at least msp430-gcc if not msp430-elf-gcc. If you insist on having gcc as a subpackage then maybe name the source package msp430-elf-toolchain, but I think that's redundant. %clean section is redundant. rm -rf %{buildroot} is redundant at the beginning of %install, too. How are these sources different from what's in Fedora? I can see they are based on gcc-4.9.1, so it would be nice to see the diff between gcc-4.9.1 and the included sources. A lot of code is bundled, some of which is also packaged in Fedora already (binutils, dejagnu, elfcpp, gas, gcc, gdb, gmp, gold, gprof, itcl, libmpc, mpfr, tcl, tk, zlib and all the lib* directories in mspgcc/sources/tools). Those that are not used during build should be deleted in %prep and those that can't be unbundled should be declared using Provides: bundled(foo) = version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx