https://bugzilla.redhat.com/show_bug.cgi?id=1303411 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- geteltorito.spec.old 2016-06-28 15:35:30.387000000 +0200 +++ geteltorito.spec 2016-06-28 16:04:52.000000000 +0200 @@ -1,13 +1,16 @@ Name: geteltorito Version: 0.6 -Release: 2%{?dist} +Release: 3%{?dist} Summary: El Torito boot image extractor License: GPLv2+ -URL: http://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito/ +URL: http://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito Source0: %{url}/%{name} Source1: %{url}/gpl.txt +BuildRequires: coreutils +BuildRequires: perl-generators + BuildArch: noarch %description @@ -35,6 +38,10 @@ %{_bindir}/%{name} %changelog +* Tue Jun 28 2016 Igor Gnatenko <ignatenko@xxxxxxxxxx> - 0.6-3 +- Add few BRs +- Trivial fixes + * Tue Jun 28 2016 Igor Gnatenko <ignatenko@xxxxxxxxxx> - 0.6-2 - Fix spelling - Trivial fixes > TODO: The %url already contains trailing slash. Please remove the slash > separator in Source0 and Source1. -URL: http://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito/ +URL: http://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito Source0: %{url}/%{name} Source1: %{url}/gpl.txt This is not the best fix. The URL value should end with a slash because the HTTP document is a directory, not a file. If you try retrieving the URL, you can see redirects leading to a URL with a slash. Moreover the final URL has https schema. Not http. The slash should be removed from Source0 and Source1 values instead. Like this: URL: https://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito/ Source0: %{url}%{name} Source1: %{url}gpl.txt > > FIX: The spec file calls "cp" command. You should build-require "coreutils". > TODO: I really recommend to do it. +BuildRequires: coreutils Ok. > FIX: Build-require `perl-generators'. +BuildRequires: perl-generators Ok. $ rpmlint geteltorito.spec ../SRPMS/geteltorito-0.6-3.fc25.src.rpm ../RPMS/noarch/geteltorito-0.6-3.fc25.noarch.rpm geteltorito.spec: W: no-%build-section (none): E: error while reading /home/test/rpmbuild/SRPMS/geteltorito-0.6-3.fc25.src.rpm: cannot use a string pattern on a bytes-like object geteltorito.noarch: W: spelling-error Summary(en_US) El -> E, L, Eli geteltorito.noarch: W: spelling-error %description -l en_US toritoimagefile -> territoriality geteltorito.noarch: W: spelling-error %description -l en_US dev -> deb, derv, div geteltorito.noarch: W: spelling-error %description -l en_US tmp -> mp, temp, tamp geteltorito.noarch: W: spelling-error %description -l en_US bootimage -> boot image, boot-image, bootlegged geteltorito.noarch: W: spelling-error %description -l en_US perl -> Perl, peel, perk geteltorito.noarch: W: spelling-error %description -l en_US bootimages -> boot images, boot-images, sabotages geteltorito.noarch: W: spelling-error %description -l en_US imagedata -> image data, image-data, imaginative geteltorito.noarch: W: spelling-error %description -l en_US eg -> eh, e, g geteltorito.noarch: W: spelling-error %description -l en_US filename -> file name, file-name, filament geteltorito.noarch: W: spelling-error %description -l en_US commandline -> command line, command-line, commandment geteltorito.noarch: W: no-documentation geteltorito.noarch: W: no-manual-page-for-binary geteltorito 1 packages and 1 specfiles checked; 0 errors, 14 warnings. rpmlint is Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=14696456). Ok. Please fix the URL and Source values before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx