[Bug 1348775] Review Request: python-unidiff - Python library to parse and interact with unified diffs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1348775



--- Comment #4 from Dan Callaghan <dcallagh@xxxxxxxxxx> ---
(In reply to Ralph Bean from comment #2)
> I see only two problems that need fixing.
> 
> 1) You're missing the python_provide macro, which we're going to use to ease
> the transition from python2 as default to python3 as default.  See an
> example usage in this specfile
> http://pkgs.fedoraproject.org/cgit/rpms/python-twiggy.git/tree/python-twiggy.
> spec and see the mention about it in the python guidelines here: 
> https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro
> 
> 2) The LICENSE file is in the %doc line (where we used to put it) but it has
> its own macro now %license.  See the spec file above for python-twiggy for
> an example.

Ah yes, I did know about both these new guidelines but I had just cargo-culted
one of my older packages which hasn't been updated to use these yet, so I
forgot...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]