Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gearman-Server - Function call "router" and load balancer Alias: perl-Gearman-Server https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245697 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-30 14:35 EST ------- OK, perl-Gearman is done and I've put it in a local repo so that I can build this. The license problem with perl-Gearman isn't repeated here. Review: * source files match upstream: 472c47d154a7168c627aad97fe04abdb3010275315e26382e13982ec4062a8cd Gearman-Server-1.09.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Gearman::Server) = 1.09 perl(Gearman::Server::Client) perl(Gearman::Server::Job) perl-Gearman-Server = 1.09-1.fc8 = /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Danga::Socket) perl(Danga::Socket) >= 1.52 perl(FindBin) perl(Gearman::Server) perl(Gearman::Server::Client) perl(Gearman::Server::Job) perl(Gearman::Util) perl(Getopt::Long) perl(IO::Socket::INET) perl(POSIX) perl(Scalar::Util) perl(Socket) perl(Sys::Hostname) perl(base) perl(fields) perl(lib) perl(strict) perl(vars) perl(warnings) * %check is present, but there's not actually a test suite to run: No tests defined for Gearman::Server extension. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review