https://bugzilla.redhat.com/show_bug.cgi?id=1303411 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- geteltorito.spec.old 2016-01-31 15:06:06.000000000 +0100 +++ geteltorito.spec 2016-06-28 15:35:30.387000000 +0200 @@ -1,24 +1,26 @@ -Name: geteltorito -Version: 0.6 -Release: 1%{?dist} -Summary: A El Torito boot image extractor - -License: GPLv2 -URL: http://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito/ -Source0: %{url}/%{name}.pl -Source1: %{url}/gpl.txt +Name: geteltorito +Version: 0.6 +Release: 2%{?dist} +Summary: El Torito boot image extractor + +License: GPLv2+ +URL: http://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito/ +Source0: %{url}/%{name} +Source1: %{url}/gpl.txt + +BuildArch: noarch %description call: geteltorito CD-image > toritoimagefile example:geteltorito /dev/sr0 > /tmp/bootimage The perl-script will extract the initial/default boot image from a CD if -existant. It will not extract any of other possibly existing bootimages +existent. It will not extract any of other possibly existing bootimages that are allowed by the El Torito standard. -The imagedata are written to STDOUT all other information is written to +The imagedata are written to STDOUT, all other information is written to STDERR (eg type and size of image). If you want to write the image to a file instead of STDOUT you can -secify the filename wanted on the commandline using option -o <filename> +specify the filename wanted on the commandline using option -o <filename>. %prep %autosetup -T -c @@ -33,5 +35,9 @@ %{_bindir}/%{name} %changelog +* Tue Jun 28 2016 Igor Gnatenko <ignatenko@xxxxxxxxxx> - 0.6-2 +- Fix spelling +- Trivial fixes + * Sun Jan 31 2016 Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> - 0.6-1 - Initial package > TODO: Use as Source0 <http://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito/geteltorito> > instead of <http://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito/geteltorito.pl>. > The files are identical while the former name matches the name you want to install it under. +Source0: %{url}/%{name} +Source1: %{url}/gpl.txt Ok. TODO: The %url already contains trailing slash. Please remove the slash separator in Source0 and Source1. > FIX: I think the license is "GPL+" because the source code states "License: GPL" and > the gpl.txt file states "If the Program does not specify a version number of > this License, you may choose any version ever published by the Free Software > Foundation" in section 9. +License: GPLv2+ Ok. Although I still think "GPL+" is correct. > FIX: Correct Summary spelling. Either remove the relading "A" or change it into "An". > FIX: Correct description. The "existant" and "secify" are misspelled. A comma is > missing in "STDOUT all", in "STDOUT you". The full stop period is missing at the end > of the description. The perl-script will extract the initial/default boot image from a CD if -existant. It will not extract any of other possibly existing bootimages +existent. It will not extract any of other possibly existing bootimages that are allowed by the El Torito standard. -The imagedata are written to STDOUT all other information is written to +The imagedata are written to STDOUT, all other information is written to STDERR (eg type and size of image). If you want to write the image to a file instead of STDOUT you can -secify the filename wanted on the commandline using option -o <filename> +specify the filename wanted on the commandline using option -o <filename>. Ok. > FIX: The spec file calls "cp" command. You should build-require "coreutils". TODO: I really recommend to do it. > FIX: Make the package noarch. Neither the Perl script, or the GPL text depend on an > architecture. +BuildArch: noarch Ok. FIX: Build-require `perl-generators'. This is a dependency required by new Perl packaging guidelines <https://fedoraproject.org/wiki/Packaging:Perl#Build_Dependencies>. Without the dependency, your binary package will miss some run-time dependencies. $ rpmlint geteltorito.spec ../SRPMS/geteltorito-0.6-2.fc25.src.rpm ../RPMS/noarch/geteltorito-0.6-2.fc25.noarch.rpm geteltorito.spec: W: no-%build-section (none): E: error while reading /home/test/rpmbuild/SRPMS/geteltorito-0.6-2.fc25.src.rpm: cannot use a string pattern on a bytes-like object geteltorito.noarch: W: spelling-error Summary(en_US) El -> E, L, Eli geteltorito.noarch: W: spelling-error %description -l en_US toritoimagefile -> territoriality geteltorito.noarch: W: spelling-error %description -l en_US dev -> deb, derv, div geteltorito.noarch: W: spelling-error %description -l en_US tmp -> mp, temp, tamp geteltorito.noarch: W: spelling-error %description -l en_US bootimage -> boot image, boot-image, bootlegged geteltorito.noarch: W: spelling-error %description -l en_US perl -> Perl, peel, perk geteltorito.noarch: W: spelling-error %description -l en_US bootimages -> boot images, boot-images, sabotages geteltorito.noarch: W: spelling-error %description -l en_US imagedata -> image data, image-data, imaginative geteltorito.noarch: W: spelling-error %description -l en_US eg -> eh, e, g geteltorito.noarch: W: spelling-error %description -l en_US filename -> file name, file-name, filament geteltorito.noarch: W: spelling-error %description -l en_US commandline -> command line, command-line, commandment geteltorito.noarch: W: no-documentation geteltorito.noarch: W: no-manual-page-for-binary geteltorito 1 packages and 1 specfiles checked; 0 errors, 14 warnings. rpmlint is Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=14689062). Ok. Please correct all `FIX' items, consider fixing `TODO' items and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx