[Bug 1302876] Review Request: clatd - CLAT / SIIT-DC Edge Relay implementation for Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1302876



--- Comment #9 from Petr Pisar <ppisar@xxxxxxxxxx> ---
(In reply to Lubomir Rintel from comment #8)
> Also, why are you packaging a snapshot instead of a released version?
> 
> > %if 0%{?fedora} > 23
> > BuildRequires:        perl-podlators
> > %endif
> 
> You can get rid of the conditional if you do a BuildRequires:
> /usr/bin/pod2man
>
Better "%{_bindir}/pod2man". If Fedora decides to move the prefix again or if
somebody wants to port the spec file to SCL.

But the condition is wrong. E.g. F23 has the program in perl-podlators package.
Actually, the first Fedora with perl-podlators is F19. Also RHEL-7 has the
package.

> > Requires:     perl(Net::IP)
> > Requires:     perl(Net::DNS)
> > Requires:     perl(IO::Socket::INET6)
> > Requires:     perl(File::Temp)
> 
> Hmm, these should be autogenerated; but only Net::IP is. Seems like the 
> dependency generator ignores requires if they don't start in column zero...
> 
Collective wisdom says indented "require" statements generates too many false
positives. Therefore generators omit them. But I'm not fully convinced about
helpfulness of the omission.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]