https://bugzilla.redhat.com/show_bug.cgi?id=1333531 --- Comment #6 from Honggang LI <honli@xxxxxxxxxx> --- Beside Michal's comments about the spec file. Please address follow issues: 1 Unix and Dos format files. https://github.com/01org/opa-ff/issues/2 opa-ff$ find -type f | xargs -n 1 file | grep CRLF | awk -F: '{print $1}' | cat -n 2 Please remove executable permission bits for C source files. opa-ff$ find -type f -executable -name '*.[ch]' 3) Please apply this patch. It fixes a building failure. diff --git a/HSM_Lib/ib_library/fm_xml.c b/HSM_Lib/ib_library/fm_xml.c index 1ad794d..e3ea5e6 100644 --- a/HSM_Lib/ib_library/fm_xml.c +++ b/HSM_Lib/ib_library/fm_xml.c @@ -3388,7 +3388,7 @@ boolean addDefaultVirtualFabric(uint32_t fm, FMXmlCompositeConfig_t *config, VFX vfp->number_of_limited_members = 0; vfp->number_of_applications = 1; - snprintf(vfp->application[0].application, sizeof(vfp->application[0].application), app->name); + snprintf(vfp->application[0].application, sizeof(vfp->application[0].application), "%s", app->name); if (!addMap(&app_config->appMap, XML_QMAP_U64_CAST app)) { freeApplicationObject(app); 4) Please replace '#!/usr/bin/env expect' with '#!/usr/bin/expect -f'. https://github.com/01org/opa-ff/pull/1 5) hardcoded compiler flags sed -i -r -e 's/(release_C(C)?OPT_Flags\s*)=/\1?=/' Makerules/Target.LINUX.GNU.* Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx