[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1323186



--- Comment #56 from Doug Ledford <dledford@xxxxxxxxxx> ---
Looking at your spec file, you are placing your license files and other
non-runtime files in your runtime java directory.  I don't know if that's
standard or not.  But there are a couple ways of solving things.

Option 1: Use the %doc macro.  The files you specify with the %doc macro will
not be placed in your app directory, they will end up in
/usr/share/doc/<package-name>-<version>/.  The %doc macro is part of your
%files stanza, and it copies the files from the source build tree to the final
destination, so you don't need to manually install any files that get the %doc
macro.  It would look something like this:

%files
%doc README THIRD-PARTY-README Third_Party_Copyright_Notices_and_Licenses

I'm not entirely sure that the license macro doesn't work similarly...ok, I
just checked, and it does.  You don't need to install the files that get the
%license macro, the macro installs the files.  So, after the %doc macro, do:

%license LICENSE gritty/gritty_license.txt

and it will copy the files from the source dir to the right target location.

After you do that, you can then re-include the parent directory for the java
app and it will get removed on uninstall as now all of these files will be in
their proper location, and that won't be in the java app directory, so there
will be no listing of the files twice.

Option 2: Use the %exclude macro in the %files section and don't fix things
like I listed above.  But, as I don't think that's the right fix here, don't
use it, I just list the %exclude macro so you are aware of it.  If you have 50
commands in /usr/bin, and 48 of them belonged in the base package, but only 2
belonged to the -devel subpacakge, then it's easiest in the main package to do

%files
/usr/bin/*
%exclude /usr/bin/command1
%exclude /usr/bin/command2

%files -devel
/usr/bin/command1
/usr/bin/command2

Given that the %license and %doc macros both add the files to the internal file
lists, if those files were still in an otherwise managed location, %exclude can
get them off of the other list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]