https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #3 from Simone Caronni <negativo17@xxxxxxxxx> --- > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "*No copyright* GPL (v2 or later)", "GPL (v2 or later)", > "Unknown or generated". 2 files have unknown license. Detailed output > of licensecheck in /home/slaanesh/Downloads/stress-ng/licensecheck.txt This is ok, but please ask upstream to include the proper headers in the files. > [!]: %build honors applicable compiler flags or justifies otherwise. > [!]: Useful -debuginfo package or justification otherwise. > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in stress- > ng-debuginfo > Checking: stress-ng-debuginfo-0.06.06-1.fc23.x86_64.rpm > stress-ng-debuginfo.x86_64: E: debuginfo-without-sources This is all related to the fact that the package ships with its own compiler flags in the Makefile: CFLAGS += -Wall -Wextra -DVERSION='"$(VERSION)"' -O2 You can probably just fix it by export the macro generated compiler flags, something like this: %build export CFLAGS=%{optflags} make %{?_smp_mflags} This should also generate binaries with debugging symbols that can then be later in the build stripped and the result used for debuginfo packages. If the all/extra/02 flags create confusion just run sed in the %prep section. Extra stuff: - Group is not needed, unless you plan to build also for epel-5. - You can substitute more stress-ng with %{name} (up to you..) - Please sort BuildRequires. There are a lot of additional compilation options that are available in the Makefile: HAVE_APPARMOR HAVE_KEYUTILS_H HAVE_XATTR_H HAVE_LIB_BSD HAVE_LIB_Z HAVE_LIB_CRYPT HAVE_LIB_RT HAVE_LIB_PTHREAD HAVE_FLOAT_DECIMAL HAVE_SECCOMP_H HAVE_LIB_AIO HAVE_SYS_CAP_H HAVE_VECMATH Maybe it's worth investing some more time into it to enable some additional features. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx