https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #53 from Doug Ledford <dledford@xxxxxxxxxx> --- (In reply to Rick Tierney from comment #52) > Neil: > > Now that you have run the review (which seems slightly different from the > way I do), I can see where some things are wrong and some things I'm not > sure why they're being flagged: > > 1. - Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/share/java/opa-fmgui/LICENSE > <RT>The "LICENSE" file appears on the install line and the %license line, > but I don't see that as a duplicate when I run the review - is that > wrong? > 4. [! ]: Package uses nothing in %doc for runtime. > <NH> Spec file should mark the readme and third-party-readme as %doc > <RT> I played with this before and kept getting warnings about file > duplication. Maybe I can mark these with the %doc macro and they will get > installed without using the "install" command. I can try that. This is the same issue: you have a minor misconception about the error message about files being listed more than once. The problem is that you have the files listed individually in the RPM via the %doc or other macro like that, then you also have them getting found by glob in the %files section of the main package. Most likely your %files includes /usr/share/java/opa-fmgui as a directory, which then pulls in all files in that directory, and as a result any files under there that are also listed in things like %doc macros will now be listed in two places and then you get the warning. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx