Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: atanks - Remake of a classic DOS game "Scorched Earth" https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246289 mmahut@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mmahut@xxxxxxxxxx Flag| |fedora-review+, fedora-cvs? ------- Additional Comments From mmahut@xxxxxxxxxx 2007-06-29 17:24 EST ------- Cool, nice work. + source files match upstream: c949306b0ad5ff7a006d932261c7e86e /usr/src/redhat/SOURCES/atanks-2.4.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + license field matches the actual license. + license is open source-compatible. + latest version is being packaged. + compiler flags are appropriate. + %clean is present. + package installs properly + debuginfo package looks complete. + rpmlint is silent. + final provides and requires are sane: [root@storm atanks]# rpm -qp --provides /usr/src/redhat/RPMS/i386/atanks-2.4-0.1.fc8.i386.rpm atanks = 2.4-0.1.fc8 [root@storm atanks]# rpm -qp --requires /usr/src/redhat/RPMS/i386/atanks-2.4-0.1.fc8.i386.rpm liballeg.so.4.2 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libm.so.6(GLIBC_2.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) [root@storm atanks]# + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + desktop file is correct Everything seems to be correct. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review