[Bug 1297854] Review Request: purple-libsteam - Adds support for Steam protocol to libpurple-based messengers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1297854



--- Comment #4 from Simone Caronni <negativo17@xxxxxxxxx> ---
> [!]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "Unknown or generated". 10 files have unknown license. Detailed
>      output of licensecheck in /home/slaanesh/Downloads/1297854-purple-
>      libsteam/licensecheck.txt

That's ok, but please ask upstream to include the appropriate headers in the
files.

> [!]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pidgin-
>      libsteam , purple-libsteam-debuginfo

Dependencies specified like this means the "pidgin-libsteam.i686" can consider
its dependencies satisfied by a "purple-libsteam.x86_64" package. Will then it
work? If it does, it's correct, if not then you should use this as a
dependency:

%{name}%{?_isa} = %{version}-%{release}

This also applies to purple-skypeweb as well, but it came to my mind now. If
the i686/x86_64 package mix does not work, please update this spec file and
re-build also the purple-skypeweb package with that.

Apart from this, package looks good!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]