https://bugzilla.redhat.com/show_bug.cgi?id=1343063 --- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to gil cattaneo from comment #2) > (In reply to Michael Simacek from comment #1) > > Package Review > > ============== > > > > Legend: > > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > [ ] = Manual review needed > > > > > > Issues: > > ======= > > - Large documentation must go in a -doc subpackage. Large could be size > > (~1MB) or number of files. > > Note: Documentation size is 1024000 bytes in 89 files. > > See: > > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Done > > - I don't like this XPath expression: > > %pom_xpath_remove pom:configuration artemis-server-osgi > > It's too general, it will remove any configuration of any plugin that > > might appear there in the future. Please make it more specific. > > - Can you put a comment about the patch above it? Done > > - There's > > artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java Done "Provides: bundled(java-base64) = 2.2.2" > > file under public domain > > - "Evil MIT" under > > /artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json > > You'll need to remove this code and replace with an alternative. You should > > also inform upstream that they bundle non-free code. > > Upstream is no interested to replace json.org with other alternative, > already contacted for other projects e.g. tika and solr. For they the > json.org license > is not a problem > > > - You should use cmake macro. > > https://fedoraproject.org/wiki/Packaging:Cmake > > - artemis-native/README contains only build instructions, it shouldn't > > be installed > > Too much work for replace json.org with an alternative. Closed this bug. > Thanks for your help i am not aware of that .... of json bundle in the code Open https://issues.apache.org/jira/browse/ARTEMIS-565 - update to 1.3.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx