[Bug 1346015] Review Request: scudcloud - Non official desktop client for Slack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1346015



--- Comment #8 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
New SPEC: https://ignatenkobrain.fedorapeople.org/for-review/scudcloud.spec
New SRPM:
https://ignatenkobrain.fedorapeople.org/for-review/scudcloud-1.24-2.fc24.src.rpm

- Package installs properly.
> Bad requires prevent package from installing - blocker
> Has a requires of lato-donts but should be lato-fonts - blocker
lato-donts -> lato-fonts
FIXED.

> Directory created not owned
FIXED by adding Requires: hicolor-icon-theme

> Packaging guidelines states that it is a MUST on .desktop packages to have a BR on desktop-file-utils - blocker
I do have BuildRequires: /usr/bin/desktop-file-validate.
I don't use any other tools. So it is perfectly fine.

> Packaging guidelines for GUI apps state there SHOULD be appdata for Gnome Software - not a blocker
As I said, don't have words to describe application, but patches are always
welcomed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]