[Bug 1346015] Review Request: scudcloud - Non official desktop client for Slack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1346015



--- Comment #4 from James Hogarth <james.hogarth@xxxxxxxxx> ---
I'll do the more detailed one tomorrow as time has run out on me tonight ...

Just a quick initial few fixes the fedora-review and mock picked up on:

Requires: lato-donts <-- obvious typo to lato-fonts which causes bad requires

As a desktop GUI application it needs to BR desktop-file-utils ... don't BR
that validate tool specifically:
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

Note that you should add appstream data if you want it to appear in
gnome-software as well:
https://fedoraproject.org/wiki/Packaging:AppData

Fix those up and I'll complete the full review and test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]