https://bugzilla.redhat.com/show_bug.cgi?id=1167175 Susi Lehtola <susi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #10 from Susi Lehtola <susi.lehtola@xxxxxx> --- (In reply to Matt Chan from comment #9) > I used sed to modify CMakeLists.txt from the spec. I'm not sure if that was > the right way to go or if I should have done the whole patch thing. You should really use patches, because sed'ing is not safe. If the section changes, sed will still run, but the text doesn't get modified. (Also, the sed command should be run in %prep, not %build.) ** You can still drop the one commented line #for i in build/tests/test*[0-9]; do $i; done ** The package has been APPROVED for inclusion in Fedora. Please make the two above changes before git import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx