[Bug 1167175] Review Request: CheMPS2 - spin-adapted DMRG for ab initio quantum chemistry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1167175



--- Comment #6 from Susi Lehtola <susi.lehtola@xxxxxx> ---
(In reply to Susi Lehtola from comment #3)
> Please note that it is not necessary to BR the -devel and the base package.
> https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

This has still not been addressed. You should drop BRs on atlas, python and
zlib, because you already require their devel packages.

**

The spec file looks *way* cleaner now.

Now, there is only one remaining issue: the build flags, which have two
problems. First, there's an -O3 flag that may override the -O2 in %{optflags}.
The default is -O2 for a reason: some of the optimizations in -O3 not only make
the code bigger, but also can inhibit the performance. You should patch out the
-O3 flag.

Also, the build scripts have added a -march=native flag. Obviously this is not
acceptable in Fedora: the binaries must run on all computers of a given
architecture, while with -march=native it is only guaranteed to run on the
exact same processor model as on the build system.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]