Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dtc - Device Tree Compiler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246186 jima@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From jima@xxxxxxxxxxxxxx 2007-06-29 12:49 EST ------- OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: tar -zxf dtc-20070628.tar.gz git clone git://www.jdl.com/software/dtc.git cd dtc git checkout d9d679fb9 rm -rf .git cd .. diff -urN dtc-20070628/ dtc/ (nada!) OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. Documentation is a little thin, but that's upstream's problem to resolve. OK - Package compiles and builds on at least one arch. (i386, ppc) OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. no - No rpmlint output. W: dtc no-version-in-last-changelog OK - final provides and requires are sane: Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) Provides: dtc = 0-0.1.20070628gitd9d679fb9.fc6 SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs My x86_64 builder is out of commission ATM, but I'll assume it works there. OK - Should function as described. As far as I can tell. :-) OK - Should have dist tag OK - Should package latest version Well, sort of. Close enough, I think. In closing, I have a bit of issue with the lack of an EVR on your changelog entries, but as long as this gets resolved at some point, I think we can let it slide. (Cue screams of bloody murder... ;-) I think we can call dtc APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review