https://bugzilla.redhat.com/show_bug.cgi?id=1346677 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-Data-Entropy-0.007-1.fc25.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Carp) 1 perl(Crypt::Rijndael) 1 perl(Data::Entropy) 1 perl(Data::Float) >= 0.008 1 perl(Errno) >= 1.00 1 perl(Exporter) 1 perl(HTTP::Lite) >= 2.2 1 perl(IO::File) >= 1.03 1 perl(Params::Classify) >= 0.000 1 perl(constant) 1 perl(integer) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Please add perl(Math::BigInt) to build and run-require, because it could be used in lib/Data/Entropy/Source.pm. $ rpm -qp --provides perl-Data-Entropy-0.007-1.fc25.noarch.rpm | sort | uniq -c 1 perl(Data::Entropy) = 0.007 1 perl(Data::Entropy::Algorithms) = 0.007 1 perl(Data::Entropy::RawSource::CryptCounter) = 0.007 1 perl(Data::Entropy::RawSource::Local) = 0.007 1 perl(Data::Entropy::RawSource::RandomOrg) = 0.007 1 perl(Data::Entropy::RawSource::RandomnumbersInfo) = 0.007 1 perl(Data::Entropy::Source) = 0.007 1 perl-Data-Entropy = 0.007-1.fc25 Binary provides are Ok. $ rpmlint ./perl-Data-Entropy* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok BuildRequires: Math::BigRat is only optional for tests FIX: Please add version to the following BRs: perl(Data::Float) >= 0.008 - lib/Data/Entropy/Algorithms.pm:48 perl(Errno) >= 1.00 - lib/Data/Entropy/RawSource/RandomOrg.pm:52 perl(HTTP::Lite) >= 2.2 - lib/Data/Entropy/RawSource/RandomOrg.pm:53 perl(IO::File) >= 1.03 - lib/Data/Entropy/RawSource/Local.pm:50 perl(Params::Classify) >= 0.000 - lib/Data/Entropy.pm perl(Test::Pod) >= 1.00 - t/pod_syn.t:5 Please correct all 'FIX' issues. Otherwise package looks good. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx