https://bugzilla.redhat.com/show_bug.cgi?id=1341642 --- Comment #10 from Ralf Senderek <fedora@xxxxxxxxxxx> --- (In reply to Tom "spot" Callaway from comment #9) > These Provides shouldn't be necessary: > > Provides: libcl.so.3 = 3.4.3 > Provides: cryptlib_py.so I have removed both. > * The %files entry for the -test subpackage is wrong. You're getting > everything from the java, perl, and python packages too and duplicating it. No, the %files entry for the -test subpackage is good. All the numerous test files are installed in this subpackage. In my last spec file the -java subpackage contained one file "/usr/lib64/cryptlib/java/cryptlib.jar" which was a duplicate. I have now removed this file from the java subpackage, so that everything in %{cryptlibdir} is in the -test package only. All other subpackages have never contributed to %{cryptlibdir} in former spec files. > To sum that up: > * You should add URLs for sources, unless they are not available anywhere > online, and if that's the case, you need to add a comment describing how to > construct that source tarball. I have put all sources on the web now, excluding the codesigning key, which must be provided by distgit instead of an URL. See the discussion here: https://fedorahosted.org/fpc/ticket/610 (comment #76) > * Are the source files useful in the -test subpackage? Yes, they are useful. The subpackage has a directory with a large number of test files that includes two header files. These test files at their proper location are used by the binary "stestlib" that checks the full functionality of cryptlib and won't work without these header files, as they contain the file names of test data to be used by stestlib. > * Please fix the end-of-line encoding in the MANIFEST. Well I have removed this file after build, because it is not necessary for the javadoc package. > * Delete the perl5 hidden files (they're not useful post-build) I've done that. And I put in a Requires: man to be able to use the standard directory and fixed the permissions of the shared perl library. > * Please remove macros from comments or replace "%" with "%%" to ensure > they're not accidentally invoked. OK, I've opted for the fancy version. Here are the new (release 5) SRPM and spec files and the KOJI build: Spec URL: https://crypto-bone.com/fedora/cryptlib.spec SRPM URL: https://crypto-bone.com/fedora/cryptlib-3.4.3-5.fc23.src.rpm KOJI: http://koji.fedoraproject.org/koji/taskinfo?taskID=14485570 I think I have addressed all your comments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx