[Bug 1335278] Review Request: mame - Multiple Arcade Machine Emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1335278



--- Comment #9 from Julian Sikorski <belegdol@xxxxxxxxx> ---
(In reply to Antonio Trande from comment #7)
> (In reply to Julian Sikorski from comment #6)
> > bgfx is not made to be linked to dynamically as per [1].
> > http-parser got dropped from upstream git and will be removed in 0.175
> > lsqlite3 got dropped from upstream git and will be removed in 0.175
> > luafilesystem and lua-zlib have no fedora packages ATM and are very tiny
> > luv on anything but rawhide is too old
> > lzma is not made to be linked dynamically
> > softfloat is not made to be linked dynamically
> > 
> > [1] http://forums.bannister.org/ubbthreads.php?ubb=showflat&Number=104437
> 
> Please, leave a comment about Provides lines.

Will do.

> 
> Just another issue: locale files are not managed by %find_lang.
> http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

This will not work unfortunately, I tried. %find_lang looks for .mo files in
%{_datadir}/locale, whereas mame puts them into %{_datadir}/%{name}.


(In reply to Neal Gompa from comment #8)
> For the source, why not use the tarball URL?
> 
> https://github.com/mamedev/%{name}/archive/%{name}0174.tar.gz
> 
> Your %setup invocation will look like this:
> 
> %setup -n %{name}-%{name}0174

The tar.gz is 33 MiB bigger than the .exe (102 vs 69). Having said that, the
Source URL needs to be updated to point to github indeed.

New packages have been uploaded:
Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec
SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.174-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]